Add a GitHub workflow to test plugin within SonarQube #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utarwyn
commented
Oct 14, 2024
sonar-plugin/src/main/java/io/ecocode/javascript/checks/AvoidHighAccuracyGeolocation.java
Outdated
Show resolved
Hide resolved
dedece35
requested changes
Oct 15, 2024
sonar-plugin/src/main/java/io/ecocode/javascript/checks/AvoidHighAccuracyGeolocation.java
Outdated
Show resolved
Hide resolved
utarwyn
force-pushed
the
sonar-healthcheck
branch
from
bcfa839 to
35bed3b
Compare
utarwyn
force-pushed
the
sonar-healthcheck
branch
from
35bed3b to
12caa2c
Compare
|
dedece35
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a new way to improve the plugin reliability: a brand new integration test with SonarQube! 🥳
A new GitHub workflow has been created using Docker Compose HealthCheck: this feature tries to start a whole set of containers and checks on them in order to determine whether or not they are “healthy”.
This allows us to check whether the plugin crashes when SonarQube starts up. We could go even further and check that at least one rule has been added to the list (via the API provided by SonarQube).